Skip to content

Adding 3 new code examples#93

Merged
malcherm merged 2 commits into
oracle-devrel:mainfrom
davcarde:main
May 26, 2026
Merged

Adding 3 new code examples#93
malcherm merged 2 commits into
oracle-devrel:mainfrom
davcarde:main

Conversation

@davcarde
Copy link
Copy Markdown
Member

  1. Wallet Rotation (Should one-time terraform operation)
  2. ADB-S secured with OCI Vault / customer-managed keys
  3. Long-term backup scheduling / retention policy example for compliance

Sign-off by: David Cardenas david.cardenas@oracle.com

1. Wallet Rotation (Should one-time terraform operation)
2. ADB-S secured with OCI Vault / customer-managed keys
3. Long-term backup scheduling / retention policy example for compliance

Sign-off by: David Cardenas david.cardenas@oracle.com
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 26, 2026
Copy link
Copy Markdown
Member

@malcherm malcherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are around the workload type of Lakehouse and default version 26ai.

}

variable "adb_workload_type" {
description = "Workload type: OLTP (ATP), DW (ADW), AJD (JSON), APEX"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add LH (Lakehouse) here after ATP

}

variable "adb_db_version" {
description = "Oracle database version"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default version should now be 26ai

adb_db_name = ""
adb_admin_password = ""
adb_compute_model = "ECPU"
adb_workload_type = "DW" # OLTP=ATP | DW=ADW | AJD=JSON | APEX
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "LH" and add LH=Lakehouse

default = "OLTP"

validation {
condition = contains(["OLTP", "DW", "AJD", "APEX"], var.adb_workload_type)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add LH

}

variable "adb_workload_type" {
description = "Workload type: OLTP (ATP), DW (ADW), AJD (JSON), APEX"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add LH (Lakehouse)

Comment thread terraform/adb_wallet_rotation/README.md Outdated
| `adb_db_name` | Database name — letters/numbers only, max 14 characters | — |
| `adb_admin_password` | ADMIN user password (sensitive) | — |
| `adb_workload_type` | Workload type: `OLTP` (ATP), `DW` (ADW), `AJD` (JSON), `APEX`, `LH` | `OLTP` |
| `adb_db_version` | Oracle database version | `19c` |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have 26ai here?

display_name = var.adb_display_name
db_name = var.adb_db_name
admin_password = var.adb_admin_password
db_workload = var.adb_workload_type # OLTP | DW | AJD | APEX
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add LH

| `adb_display_name` | Display name in the OCI console | — |
| `adb_db_name` | Database name — letters/numbers only, max 14 characters | — |
| `adb_admin_password` | ADMIN user password (sensitive) | — |
| `adb_workload_type` | Workload type: `OLTP` (ATP), `DW` (ADW), `AJD` (JSON), `APEX` | `OLTP` |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add LH (Lakehouse)

Signed-off by: David Cardenas david.cardenas@oracle.com
@malcherm malcherm merged commit fe86e0c into oracle-devrel:main May 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants